phonic: configsForTools per-tool config passthrough (+ forbid_tool_call_after_speech) - #4
Closed
arunwpm-work wants to merge 7 commits into
Closed
phonic: configsForTools per-tool config passthrough (+ forbid_tool_call_after_speech)#4arunwpm-work wants to merge 7 commits into
arunwpm-work wants to merge 7 commits into
Conversation
…ll_after_speech)
Replace the forbid_speech_after_tool_call: list[str] option with configs_for_tools:
list[PhonicToolConfig] — one object per tool ({name, ...}) carrying up to the full
behavior set (wait_for_speech_before_tool_call, forbid_speech_after_tool_call,
forbid_tool_call_after_speech, allow_tool_chaining); omitted fields fall back to the
plugin defaults. The plugin forwards each object as the tool's Phonic tool_config
(passthrough) and reads forbid_speech_after_tool_call for its own assistant-turn logic.
Adds forbid_tool_call_after_speech (echo drops the tool call if the agent spoke that
turn). Supersedes the un-PR'd arun/phonic-forbid-speech-after-tool-call branch.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…or-tools # Conflicts: # livekit-plugins/livekit-plugins-phonic/livekit/plugins/phonic/realtime/realtime_model.py
Add the remaining per-tool field (require_speech_before_tool_call) and move the per-field behavior docs out of inline comments/docstrings into the plugin README. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…configurable Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Re-add the removed forbid_speech_after_tool_call: list[str] option for backwards compatibility. It logs a deprecation warning and folds each listed tool into configs_for_tools (an explicit configs_for_tools entry wins). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Collaborator
Author
|
Superseded by the upstream contribution livekit#6634 — livekit maintains the phonic plugin in-tree, so landing it upstream is the right home. The fork will pick it up on its next sync. |
Collaborator
Author
|
Reopening — Ashby runs on this fork, so the feature (forbid_tool_call_after_speech) needs to land here now rather than waiting on the upstream contribution (livekit#6634). This will be merged into the fork; the fork reconciles with upstream on its next sync. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
configs_for_toolsto the Phonic realtime model — per-tool behavior overrides forwarded to Phonic's tool config. One entry per tool (keyed byname); each may setrequire_speech_before_tool_call,forbid_speech_after_tool_call, andforbid_tool_call_after_speech. Omitted fields fall back to the plugin defaults; tools with no entry are unchanged.Replaces the previous
forbid_speech_after_tool_call: list[str]option (that behavior is now a per-tool field). See the README for the field reference.